Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outputs.tf #13

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Update outputs.tf #13

merged 5 commits into from
Oct 24, 2024

Conversation

NBIX-Robert-Suarez
Copy link
Contributor

Adding execution role to the outputs

Adding execution role to the outputs
@NBIX-Robert-Suarez NBIX-Robert-Suarez requested a review from a team as a code owner October 21, 2024 23:05
Copy link
Collaborator

@pxc-dev pxc-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!! I made one suggestion regarding specifying the field from the resource. Also, you would need to bump the version here to 1.0.1 and add this new output to the README here. I'm happy to take care of those if you prefer. I appreciate it.

outputs.tf Outdated Show resolved Hide resolved
Updating the wrapper version
@NBIX-Robert-Suarez
Copy link
Contributor Author

NBIX-Robert-Suarez commented Oct 22, 2024

Thanks for the contribution!! I made one suggestion regarding specifying the field from the resource. Also, you would need to bump the version here to 1.0.1 and add this new output to the README here. I'm happy to take care of those if you prefer. I appreciate it.

Updated both requested areas

@pxc-dev
Copy link
Collaborator

pxc-dev commented Oct 24, 2024

Thanks again for the contribution! I made some minor formatting changes and updated the descriptions to be consistent.

@pxc-dev pxc-dev merged commit ca9c82e into monte-carlo-data:main Oct 24, 2024
2 checks passed
@pxc-dev
Copy link
Collaborator

pxc-dev commented Oct 24, 2024

This has been released as version 1.0.1: https://registry.terraform.io/modules/monte-carlo-data/mcd-agent/aws/1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants